[
https://issues.apache.org/jira/browse/OPENNLP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636212#comment-17636212
]
ASF GitHub Bot commented on OPENNLP-1320:
-----------------------------------------
rzo1 opened a new pull request, #436:
URL: https://github.com/apache/opennlp/pull/436
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Additional Notes
This is a PR on the basis of https://github.com/apache/opennlp/pull/385 with
the JUnit 4 test by @avanco
As commented in https://github.com/apache/opennlp/pull/385, this PR proposes
to re-create and dispose the `DictionaryLookup`, which is " is cheap to create
and dispose (so it makes no sense to cache)" according to
https://github.com/morfologik/morfologik-stemming/issues/69 - it avoids the
explicit sychronization of the method.
I did not squash the commits to retain @avanco code contributions /
authorship.
> Makes lemmatize of MorfologikLemmatizer thread-safe
> ---------------------------------------------------
>
> Key: OPENNLP-1320
> URL: https://issues.apache.org/jira/browse/OPENNLP-1320
> Project: OpenNLP
> Issue Type: Bug
> Reporter: Lucas Avanço
> Priority: Major
>
> The method lemmatize of MorfologikLemmatizer is not thread-safe.
> Concurrent invokes may rise exceptions and return unpredictable resutls.
> It seems that the whole method must be sync because the variable returned by
> the morfologik lib is shared between threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
