[
https://issues.apache.org/jira/browse/OPENNLP-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639961#comment-17639961
]
ASF GitHub Bot commented on OPENNLP-1341:
-----------------------------------------
kinow commented on code in PR #440:
URL: https://github.com/apache/opennlp/pull/440#discussion_r1033416140
##########
opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java:
##########
@@ -28,6 +28,9 @@
import opennlp.tools.util.InputStreamFactory;
import opennlp.tools.util.ObjectStream;
+/**
+ * <b>Note:</b> Do not use this class, internal use only!
+ */
Review Comment:
In Apache Commons I think it is common to have an "internal" subpackage for
classes that must not be used by external users. Maybe we should move these
classes too? That way you could quickly identify use of internal API classes in
other projects.
> Make the ConlluPOSSampleStream constructor public
> -------------------------------------------------
>
> Key: OPENNLP-1341
> URL: https://issues.apache.org/jira/browse/OPENNLP-1341
> Project: OpenNLP
> Issue Type: Wish
> Components: POS Tagger
> Affects Versions: 1.9.3
> Environment: Windows
> Reporter: Reece H. Dunn
> Priority: Trivial
> Labels: easyfix
>
> The constructor for ConlluPOSSampleStream is currently package private as it
> does not have a public/private keyword before it. Making it public will allow
> an application to create that stream for use in training a POS model.
> The other conllu stream classes (ConlluStream, ConlluLemmaSampleStream,
> ConlluTokenSampleStream, ConlluSentenceSampleStream) have public
> constructors, allowing them to be used in training their respective models.
> The ConlluPOSSampleStreamFactory and ConlluLemmaSampleStreamFactory classes
> are marked as internal use only, and rely on an API suited to the opennlp
> cli. Note: ConlluSentenceSampleStreamFactory and
> ConlluTokenSampleStreamFactory are missing an internal use only comment, but
> should have one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
