[
https://issues.apache.org/jira/browse/OPENNLP-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640923#comment-17640923
]
ASF GitHub Bot commented on OPENNLP-936:
----------------------------------------
rzo1 commented on code in PR #69:
URL: https://github.com/apache/opennlp/pull/69#discussion_r1035244652
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTaggerME_TS.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools.postag;
+
+import opennlp.tools.util.Sequence;
+
+/**
+ * A thread-safe version of the POSTaggerME. Using it is completely
transparent. You can use it in
+ * a single-threaded context as well, it only incurs a minimal overhead.
+ */
+public class POSTaggerME_TS implements POSTagger {
Review Comment:
> I'd vote the wrapper is sufficient. I appreciate the work on this.
+1
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTaggerME_TS.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools.postag;
+
+import opennlp.tools.util.Sequence;
+
+/**
+ * A thread-safe version of the POSTaggerME. Using it is completely
transparent. You can use it in
+ * a single-threaded context as well, it only incurs a minimal overhead.
+ */
+public class POSTaggerME_TS implements POSTagger {
Review Comment:
> I'd vote the wrapper is sufficient. I appreciate the work on this.
+1
> Add thread safe versions of some tools (ME sentence detection, tokenization,
> pos tagging)
> -----------------------------------------------------------------------------------------
>
> Key: OPENNLP-936
> URL: https://issues.apache.org/jira/browse/OPENNLP-936
> Project: OpenNLP
> Issue Type: Improvement
> Components: POS Tagger
> Affects Versions: 1.7.1
> Reporter: Thilo Goetz
> Priority: Minor
>
> As discussed on the mailing list, add thread safe versions of maximum entropy
> sentence detection, tokenization and pos tagging.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
