[
https://issues.apache.org/jira/browse/OPENNLP-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645242#comment-17645242
]
ASF GitHub Bot commented on OPENNLP-1406:
-----------------------------------------
rzo1 commented on code in PR #449:
URL: https://github.com/apache/opennlp/pull/449#discussion_r1044334326
##########
opennlp-tools/src/main/java/opennlp/tools/parser/ParserEventTypeEnum.java:
##########
@@ -19,13 +19,14 @@
package opennlp.tools.parser;
/**
- * Enumerated type of event types for the parser.
+ * Enumeration of event types for a {@link Parser}.
*/
public enum ParserEventTypeEnum {
BUILD,
CHECK,
+ // TODO Add reason why those enum values are deprecated
Review Comment:
+1
##########
opennlp-tools/src/main/java/opennlp/tools/parser/ParserModel.java:
##########
@@ -41,16 +41,15 @@
import opennlp.tools.util.model.POSModelSerializer;
/**
- * This is an abstract base class for {@link ParserModel} implementations.
+ * This is the default {@link ParserModel} implementation.
*/
-// TODO: Model should validate the artifact map
Review Comment:
Is this still a valid todo?
> Enhance JavaDoc in opennlp.tools.parser package
> -----------------------------------------------
>
> Key: OPENNLP-1406
> URL: https://issues.apache.org/jira/browse/OPENNLP-1406
> Project: OpenNLP
> Issue Type: Improvement
> Components: Documentation, Parser
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.1.1
>
>
> The JavaDoc the _opennlp.tools.parser_ package suffers from several
> inconsistencies and missing descriptions. Moreover, several typos are present
> that need sanitizing.
> It needs enhancements and/or additions to provide more clarity for readers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
