[
https://issues.apache.org/jira/browse/OPENNLP-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645353#comment-17645353
]
ASF GitHub Bot commented on OPENNLP-1187:
-----------------------------------------
mawiesne opened a new pull request, #452:
URL: https://github.com/apache/opennlp/pull/452
Change
-
- adds `NaiveBayesEvalParameters` by computation of the outcome total
values, as proposed by reporter 'agarg98'
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Issue in finding accuracy of model
> ----------------------------------
>
> Key: OPENNLP-1187
> URL: https://issues.apache.org/jira/browse/OPENNLP-1187
> Project: OpenNLP
> Issue Type: Bug
> Components: Doccat, Machine Learning
> Affects Versions: 1.8.4
> Reporter: Aman Garg
> Priority: Major
> Fix For: 2.1.1
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> the trainingStats function in NaiveBayesTrainer class is not working properly
> and display wrong result.
> In findParameters(), at line 154 i.e.
> EvalParameters evalParams = new EvalParameters(params, numOutcomes);
> should be replaced by following block:
>
> double[] outcomeTotals = new double[outcomeLabels.length];
> for (int i = 0; i < params.length; ++i) {
> Context context = params[i];
> for (int j = 0; j < context.getOutcomes().length; ++j) {
> int outcome = context.getOutcomes()[j];
> double count = context.getParameters()[j];
> outcomeTotals[outcome] += count;
> }
> }
> evalParams = new NaiveBayesEvalParameters(params,
> outcomeLabels.length, outcomeTotals, predLabels.length);
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
