[
https://issues.apache.org/jira/browse/OPENNLP-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648089#comment-17648089
]
ASF GitHub Bot commented on OPENNLP-1412:
-----------------------------------------
mawiesne opened a new pull request, #458:
URL: https://github.com/apache/opennlp/pull/458
Change
-
- adds specific `equals` and `hashCode` implementations for `TokenizerModel`
and `ParserModel`.
- introduces new test dependency `junit-jupiter-params` (test-scoped) to
_opennlp-tools_ for more flexible test setups.
- improves `TokenizerModelTest`, `treeinsert.ParserTest` and
`chunking.ParserTest` by adding further assertions and fixes TODOs.
- adds `AbstractParserModelTest` to avoid code duplication, simplifying
existing test cases.
- adds another `Parse` example to demonstrate how easy it is to check
different examples without duplicating code.
- removes uncommented code from both `ParserTest` variants
(chunker/treeinsert) by providing actual assertions instead!
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Provide equals and hashCode for ParserModel and TokenizerModel
> --------------------------------------------------------------
>
> Key: OPENNLP-1412
> URL: https://issues.apache.org/jira/browse/OPENNLP-1412
> Project: OpenNLP
> Issue Type: Improvement
> Components: Parser, Tokenizer
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.1.1
>
>
> The tests {_}opennlp.tools.tokenize.{*}TokenizerModelTest{*}{_},
> {_}opennlp.tools.parser.chunking.{_}{*}_ParserTest_{*}, and
> {_}opennlp.tools.parser.treeinsert.{_}{*}_ParserTest_{*} signal by TODOs that
> no actual assertions are made to check whether (de-)serialized Model
> instances are correctly read in again.
> In other words: Those (Tokenizer/Parser) models lacks a valid equals/hashCode
> implementation by which one could verify a valid state (=equality) after
> (de-)serialization has occurred.
> Aim:
> * Provide an improved implementation of the related "Model" classes.
> * Remove existing TODOs in _TokenizerModelTest_ and _ParserTest_
> * Improve the three test classes with further test assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
