[
https://issues.apache.org/jira/browse/OPENNLP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675528#comment-17675528
]
ASF GitHub Bot commented on OPENNLP-1437:
-----------------------------------------
rzo1 commented on code in PR #487:
URL: https://github.com/apache/opennlp/pull/487#discussion_r1066914169
##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -90,12 +68,8 @@ public static Number parse(String number, String
languageCode)
}
Locale locale = new Locale(languageCode);
-
NumberFormat numberFormat = NumberFormat.getInstance(locale);
-
- number = number.trim();
- number = removeChar(number, ' ');
-
+ number = number.replaceAll("\\s", "");
Review Comment:
Possible follow up: https://issues.apache.org/jira/browse/OPENNLP-1441
(created in discussion with @mawiesne to improve performance throughout the
code base)
##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -90,12 +68,8 @@ public static Number parse(String number, String
languageCode)
}
Locale locale = new Locale(languageCode);
-
NumberFormat numberFormat = NumberFormat.getInstance(locale);
-
- number = number.trim();
- number = removeChar(number, ' ');
-
+ number = number.replaceAll("\\s", "");
Review Comment:
Possible follow up: https://issues.apache.org/jira/browse/OPENNLP-1441
(created in discussion with @mawiesne to improve performance throughout the
code base). Martin will have a look.
> Change removeChar() in NumberUtil.java with String.replaceAll
> -------------------------------------------------------------
>
> Key: OPENNLP-1437
> URL: https://issues.apache.org/jira/browse/OPENNLP-1437
> Project: OpenNLP
> Issue Type: Task
> Reporter: Jeff Zemerick
> Assignee: Atita Arora
> Priority: Major
>
> Change removeChar() in NumberUtil.java with String.replaceAll(). See the
> conversation on the pull request at
> [https://github.com/apache/opennlp/pull/479/files.]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
