[
https://issues.apache.org/jira/browse/OPENNLP-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690609#comment-17690609
]
ASF GitHub Bot commented on OPENNLP-1466:
-----------------------------------------
mawiesne opened a new pull request, #500:
URL: https://github.com/apache/opennlp/pull/500
Change
-
- converts codebase to use `Collection#toArray(0)`
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Convert the use of Collection#toArray(..) more performant version under
> modern JVMs
> -----------------------------------------------------------------------------------
>
> Key: OPENNLP-1466
> URL: https://issues.apache.org/jira/browse/OPENNLP-1466
> Project: OpenNLP
> Issue Type: Task
> Affects Versions: 2.1.0, 2.1.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Major
>
> In older Java versions, using a pre-sized array was preferred, as the
> reflection call necessary to create an array of pre-computed size was rather
> slow. However, since Java 6+, the performance of the empty array version the
> same, and sometimes even better. [1] [2]
> The code of many OpenNLP classes still relies on the old style of converting
> collections to arrays, via {{someCollection.toArray(...size()) or similar, in
> essence: via a pre-computed length. However, the zero-sized initialization is
> considered (and demonstrated) to be faster under Java 11+ vms. [3]}}
> Aims
> * Migrate the old way of creating / converting to arrays to the more
> performant version.
> * Ensure all tests hold no drawbacks show up.
>
> [1]:
> [https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_new_reflective_array]
> [2]:
> [https://www.baeldung.com/java-collection-toarray-methods#performance-trials]
> [3]:
> [https://www.baeldung.com/java-collection-toarray-methods#benchmarks-on-newer-jdks]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
