[
https://issues.apache.org/jira/browse/OPENNLP-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690724#comment-17690724
]
ASF GitHub Bot commented on OPENNLP-1468:
-----------------------------------------
kinow commented on code in PR #502:
URL: https://github.com/apache/opennlp/pull/502#discussion_r1110866692
##########
opennlp-tools/src/test/java/opennlp/tools/util/VersionTest.java:
##########
@@ -63,6 +63,6 @@ void testParseInvalidVersion2() {
return;
}
- Assertions.assertTrue(false);
+ Assertions.fail();
Review Comment:
:smile: that was definitely one way to make the test fail
> Simplify test assertions in JUnit tests
> ---------------------------------------
>
> Key: OPENNLP-1468
> URL: https://issues.apache.org/jira/browse/OPENNLP-1468
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
> Affects Versions: 2.1.0, 2.1.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
>
> Some existing Test assertions can be simplified so they read more clearly.
> Aim:
> * Simplify tests assertions to be / read less complex
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
