[
https://issues.apache.org/jira/browse/OPENNLP-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690907#comment-17690907
]
ASF GitHub Bot commented on OPENNLP-1471:
-----------------------------------------
mawiesne commented on PR #505:
URL: https://github.com/apache/opennlp/pull/505#issuecomment-1436008087
@kinow Thanks for your feedback & improvements.
> Ensure Dictionary#asStringSet() implements hashCode() and equals() correctly
> ----------------------------------------------------------------------------
>
> Key: OPENNLP-1471
> URL: https://issues.apache.org/jira/browse/OPENNLP-1471
> Project: OpenNLP
> Issue Type: Improvement
> Affects Versions: 2.1.0, 2.1.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
>
> The tests (a) {{DictionaryAsSetCaseInsensitiveTest}} and
> {{(b) DictionaryAsSetCaseSensitiveTest}} have an open TODO that points to a
> bug in Dictionary#asStringSet()
>
> {quote}// TODO: should it be equal??
> Assertions.assertNotSame(setA.hashCode(), setB.hashCode());
> {quote}
> To cure this, the implementation of Dictionary#asStringSet() needs override
> hashCode and equals properly.
> After fixing the implementation, the following assertion must hold:
> {quote}Assertions.assertEquals(setA, setB);
> Assertions.assertEquals(setA.hashCode(), setB.hashCode());
> {quote}
> where setA and setB are obtained via {{{}Dictionary#asStringSet(){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
