[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693167#comment-17693167
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116877895
##########
opennlp-tools/src/test/java/opennlp/tools/cmdline/tokenizer/TokenizerTrainerToolTest.java:
##########
@@ -104,7 +108,10 @@ public void testTestRunHappyCase() throws IOException {
model.delete();
}
- @Test
+ //TODO OPENNLP-1447
+ @Disabled(value = "OPENNLP-1447: These kind of tests won't work anymore. " +
+ "We need to find a way to redirect log output (i.e. implement " +
+ "a custom log adapter and plug it in, if we want to do such tests.")
Review Comment:
The log watcher approach as outlined in the thread looks promising. I will
add a reference in OPENNLP-1447
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
