[
https://issues.apache.org/jira/browse/OPENNLP-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694398#comment-17694398
]
ASF GitHub Bot commented on OPENNLP-1449:
-----------------------------------------
rzo1 opened a new pull request, #509:
URL: https://github.com/apache/opennlp/pull/509
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Adjusted log messages according to review comments by @mawiesne in
https://github.com/apache/opennlp/pull/492
> Revise log levels in OpenNLP
> ----------------------------
>
> Key: OPENNLP-1449
> URL: https://issues.apache.org/jira/browse/OPENNLP-1449
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> After introducing slf4j in OpenNLP, we should discuss the log levels.
> We have a lot of different variants in the code base:
> - System.err
> - System.out
> - "[WARN] ..." via System.err / System.println
> - "[ERROR] ..." via System.err / System.println
> Goal is to define / discuss proper log levels as provided by SLF4J (trace,
> debug, etc.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
