[ 
https://issues.apache.org/jira/browse/OPENNLP-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696290#comment-17696290
 ] 

ASF GitHub Bot commented on OPENNLP-1475:
-----------------------------------------

mawiesne opened a new pull request, #511:
URL: https://github.com/apache/opennlp/pull/511

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for 
build issues and submit an update to your PR as soon as possible.
   




> Update build dependency forbiddenapis to version 3.4
> ----------------------------------------------------
>
>                 Key: OPENNLP-1475
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1475
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Build, Packaging and Test
>    Affects Versions: 2.1.0, 2.1.1
>            Reporter: Martin Wiesner
>            Priority: Trivial
>             Fix For: 2.1.2
>
>
> OpenNLP references an outdated version of the 
> [forbidden-apis|https://github.com/policeman-tools/forbidden-apis] maven 
> plugin, that is version 2.7. The most version 3.4 resolves several bugs and 
> improves support for newer JDK versions - details see:
> [https://github.com/policeman-tools/forbidden-apis/wiki/Changes]
> Aim:
>  * Modernize forbidden-apis to latest version 3.4
>  * Add support for checks on newer JDK versions



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to