[
https://issues.apache.org/jira/browse/OPENNLP-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696437#comment-17696437
]
ASF GitHub Bot commented on OPENNLP-1474:
-----------------------------------------
mawiesne opened a new pull request, #516:
URL: https://github.com/apache/opennlp/pull/516
Change
-
- adds Spanish and Italian alphabet regex patterns to `...lang.Factory`
- adjusts German pattern to include `é` and `É` to cover established loan
words such as "Café" or "Cuvée"
- adjusts `TokenizerFactoryTest` to use langCode "eng" instead of "spa" as
Spanish will (now) return a specialized pattern
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Create tokenizer factories for other langs (Spanish, Italian, ...)
> ------------------------------------------------------------------
>
> Key: OPENNLP-1474
> URL: https://issues.apache.org/jira/browse/OPENNLP-1474
> Project: OpenNLP
> Issue Type: Improvement
> Components: Tokenizer
> Affects Versions: 2.1.1
> Reporter: Bruno P. Kinoshita
> Priority: Major
> Fix For: 2.2.0
>
>
> From [https://github.com/apache/opennlp/pull/506#issuecomment-1445849746]
> We can create more factories for languages such as Spanish and Italian. For
> example:
> {noformat}
> // From: https://it.wikipedia.org/wiki/Alfabeto_italiano
> private static final Pattern ITALIAN =
> Pattern.compile("^[0-9a-zàèéìîíòóùüA-ZÀÈÉÌÎÍÒÓÙÜ]+$");
> // From: https://en.wikiversity.org/wiki/Alphabet/Spanish_alphabet &
> https://en.wikipedia.org/wiki/Spanish_orthography#Alphabet_in_Spanish &
> https://www.fundeu.es/consulta/tilde-en-la-y-y-griega-o-ye-24786/
> private static final Pattern SPANISH =
> Pattern.compile("^[0-9a-záéíóúüýñA-ZÁÉÍÓÚÝÑ]+$"); {noformat}
> Community feedback would be appreciated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
