[
https://issues.apache.org/jira/browse/OPENNLP-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714735#comment-17714735
]
ASF GitHub Bot commented on OPENNLP-1454:
-----------------------------------------
mawiesne opened a new pull request, #101:
URL: https://github.com/apache/opennlp-sandbox/pull/101
Changes
-
- replaces many occurrences of Syouts and printStacktrace(), and JUL logging
with SLF4J as used in OPENNLP tools
- introduces log4j-2.x as (managed) runtime binding for slj4j in
`opennlp-similarity`
- improves JavaDoc along the path
- improves code formatting along the path
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Convert System.out statements to debug logging statements in
> 'opennlp-similarity' sandbox component
> ---------------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1454
> URL: https://issues.apache.org/jira/browse/OPENNLP-1454
> Project: OpenNLP
> Issue Type: Task
> Components: Similarity
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Priority: Minor
>
> In several classes of the 'opennlp-similarity' sandbox component, commented
> System.out statements exist that have a debug statement flavor. Yet, in tests
> and at runtime those spam the console quite heavily. That's why those have
> been commented out during the compatibility migration towards tools version
> 2.1.x conducted for all sandbox components.
> The aim of that issue is to convert those spammy log behavior by making use
> of the slf4j-api. The code contains the spots marked with a TODO notice and
> this issue number for which a switch to a logging framework with "trace" or
> "debug" levels could be considered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
