[
https://issues.apache.org/jira/browse/OPENNLP-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733890#comment-17733890
]
ASF GitHub Bot commented on OPENNLP-1174:
-----------------------------------------
rzo1 opened a new pull request, #541:
URL: https://github.com/apache/opennlp/pull/541
### For all changes:
- [x ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that the format looks appropriate for the output in
which it is rendered?
### Note
I created a paramterized Jenkins job to run the eval tests for a given
repository / branch. The removal of the classic xml config format has no (side)
effect on the eval tests:
https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/3/
> remove classic format support in feature generator XML config when it is no
> longer needed
> -----------------------------------------------------------------------------------------
>
> Key: OPENNLP-1174
> URL: https://issues.apache.org/jira/browse/OPENNLP-1174
> Project: OpenNLP
> Issue Type: Planned Work
> Reporter: Koji Sekiguchi
> Assignee: Richard Zowalla
> Priority: Minor
>
> I put many "TODO" marks in the patch for OPENNLP-1154, e.g.:
> {code:java}
> @Deprecated // TODO: just remove when back-compat is no longer needed
> static void register(Map<String, GeneratorFactory.XmlFeatureGeneratorFactory>
> factoryMap) {
> factoryMap.put("generators", new AggregatedFeatureGeneratorFactory());
> }
> {code}
> Before merging it, I'd like to create this ticket to get ticket number and
> add the number in the patch for OPENNLP-1154 so that we can easily find
> unnecessary codes when we want to remove in the future..
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
