[ 
https://issues.apache.org/jira/browse/OPENNLP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739915#comment-17739915
 ] 

ASF GitHub Bot commented on OPENNLP-1501:
-----------------------------------------

jzonthemtn commented on PR #540:
URL: https://github.com/apache/opennlp/pull/540#issuecomment-1620205255

   > > we could re-add the Getters and mark them with 
@deprecated(forRemoval=true)
   > 
   > I will update the PR for records which were _public_ classes before 
including the previous accessor methods, deprecated with "for removal" 
indicator on.
   
   Looks great. Thanks!




> Make use of Records and Pattern Matching for instanceof
> -------------------------------------------------------
>
>                 Key: OPENNLP-1501
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1501
>             Project: OpenNLP
>          Issue Type: Improvement
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>
> With the recent move to Java 17 (see: OpenNLP-1496), we can now modernize 
> some classes to reduce boilerplate code.
> Aims:
>  * Make use of Java records, see: [https://openjdk.org/jeps/395]
>  * Make use of Pattern Matching for instanceof, see: 
> [https://openjdk.org/jeps/394]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to