[
https://issues.apache.org/jira/browse/OPENNLP-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794512#comment-17794512
]
ASF GitHub Bot commented on OPENNLP-1479:
-----------------------------------------
l-ma commented on PR #559:
URL: https://github.com/apache/opennlp/pull/559#issuecomment-1846545078
Thank you for your welcoming words! I've added some more tests (thanks to
@juhyep for helping).
The tests now have a lot of duplicated code. Do you want me to extract the
common code into a helper method? I saw that some other tests such as
`SentenceDetectorMEGermanTest` have duplicated code, so I'm not sure what you
prefer.
> Write better tests for pattern verification (tokenizers)
> --------------------------------------------------------
>
> Key: OPENNLP-1479
> URL: https://issues.apache.org/jira/browse/OPENNLP-1479
> Project: OpenNLP
> Issue Type: Improvement
> Components: Tokenizer
> Affects Versions: 2.1.1
> Reporter: Bruno P. Kinoshita
> Assignee: Lara Marinov
> Priority: Major
> Fix For: 2.3.2
>
>
> From [https://github.com/apache/opennlp/pull/516#issuecomment-1455015772]
> At the moment our tests verify that the tokenizer objects are created
> correctly (i.e. tests getters and setters, constructor, etc.), without
> verifying the actual behavior when used in conjunction with other classes
> (factory, tokenizer, trainers, etc).
> It would be best to test the patterns used in the factories for different
> languages with some interesting sample data (maybe something from project
> gutenberg, open source news sites, etc.).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
