[
https://issues.apache.org/jira/browse/OPENNLP-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795031#comment-17795031
]
ASF GitHub Bot commented on OPENNLP-1525:
-----------------------------------------
mawiesne opened a new pull request, #562:
URL: https://github.com/apache/opennlp/pull/562
Change
-
- enhances TokenizerME impl to make use of abbreviations if available in
TokenizerModel
- adjusts expectation in
TokenizerFactoryTest#testCustomPatternForTokenizerMEDeu to 14 tokens
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Improve TokenizerME to make use of abbreviations provided in TokenizerModel
> ---------------------------------------------------------------------------
>
> Key: OPENNLP-1525
> URL: https://issues.apache.org/jira/browse/OPENNLP-1525
> Project: OpenNLP
> Issue Type: Improvement
> Components: Tokenizer
> Affects Versions: 2.3.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.2
>
> Original Estimate: 2h
> Time Spent: 1h 25m
> Remaining Estimate: 35m
>
> While working on OPENNLP-1479 and reviewing a PR by [~l-ma], we identified
> that {{TokenizerME}} doesn't make use of locale/language specific
> abbreviations provided via the corresponding TokenizerModel.
> Therefore, terms will get mis-tokenized if they are abbreviated, such as the
> German token "S." which represents an abbreviated form of "Seite" (-> page).
> Instead of being tokenized as ["S."], TokenizerME will incorrectly yield:
> ["S", "."].
> Improvement suggested:
> - Make use of the abbreviations dictionary provided by the {{TokenizerModel}}
> - Adapt the idea suggested and implemented in OPENNLP-570
> ({{SentenceDetectorME}}) for {{TokenizerME}}
> - Adjust {{TokenizerFactoryTest}} method testCustomPatternForTokenizerMEDeu()
> for German abbreviations, see sent-detector test case. It should expect and
> result in 14 tokens, instead of 16 - so there is a TODO here.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
