[
https://issues.apache.org/jira/browse/OPENNLP-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796573#comment-17796573
]
ASF GitHub Bot commented on OPENNLP-1526:
-----------------------------------------
rzo1 commented on code in PR #566:
URL: https://github.com/apache/opennlp/pull/566#discussion_r1426239060
##########
opennlp-tools/src/test/java/opennlp/tools/sentdetect/AbstractSentenceDetectorTest.java:
##########
@@ -29,11 +29,15 @@
import opennlp.tools.util.TrainingParameters;
public abstract class AbstractSentenceDetectorTest {
-
+
+ protected static final Locale LOCALE_SPANISH = new Locale("es");
Review Comment:
Great - didn't know, that there is no constant in the JDK for it. Weird.
> Add Spanish abbreviation dictionary
> -----------------------------------
>
> Key: OPENNLP-1526
> URL: https://issues.apache.org/jira/browse/OPENNLP-1526
> Project: OpenNLP
> Issue Type: Improvement
> Components: Sentence Detector, Tokenizer
> Affects Versions: 2.3.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: abb_ES.xml
>
> Time Spent: 1h
> Remaining Estimate: 1h
>
> Similar to the addition in OPENNLP-570, an abbreviation dictionary for
> Spanish sentence detection and tokenisation might be beneficial.
> Aims:
> - Create and add a new file {{abb_ES.xml}} to _opennlp-tools/lang/es_
> - Add basic set of test cases
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
