[
https://issues.apache.org/jira/browse/OPENNLP-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799359#comment-17799359
]
ASF GitHub Bot commented on OPENNLP-1369:
-----------------------------------------
rzo1 opened a new pull request, #571:
URL: https://github.com/apache/opennlp/pull/571
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit? -> can be done
via GitHub squashing
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
This is a following up of https://github.com/apache/opennlp/pull/417 with a
unit test to reproduce the issue. Joined work with @mawiesne with :coffee: in
the office today ;-)
> NPE when serializing a TokenNameFinder model trained with
> POSTaggerNameFeatureGeneratorFactory
> ----------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1369
> URL: https://issues.apache.org/jira/browse/OPENNLP-1369
> Project: OpenNLP
> Issue Type: Bug
> Affects Versions: 2.0.0, 2.1.0, 2.2.0, 2.3.0
> Reporter: Lucas Avanço
> Assignee: Richard Zowalla
> Priority: Major
> Fix For: 2.3.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There is an issue of null pointer when trying to serialize a TokenNameFinder
> model trained using as one of feature generators
> POSTaggerNameFeatureGeneratorFactory.
> In this method
> opennlp.tools.util.model.{*}BaseModel#serialize{*}(java.io.OutputStream)
> there is a for which iterates over the artifactMap of the POS-model that must
> be serialized together, but a NPE occurs because *generator.featuregen* is
> not found inside of *pt-pos-perceptron.zip*
>
> <generator
> class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
> <int name="prevLength">2</int>
> <int name="nextLength">2</int>
> <generator
> class="opennlp.tools.util.featuregen.POSTaggerNameFeatureGeneratorFactory">
> <str name="model">pt-pos-perceptron.zip</str>
> </generator>
> </generator>
>
> This is the POS-tagger model used:
> http://opennlp.sourceforge.net/models-1.5/pt-pos-perceptron.bin
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
