[
https://issues.apache.org/jira/browse/OPENNLP-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800857#comment-17800857
]
ASF GitHub Bot commented on OPENNLP-1446:
-----------------------------------------
rzo1 commented on code in PR #113:
URL: https://github.com/apache/opennlp-sandbox/pull/113#discussion_r1437218471
##########
opennlp-wsd/src/test/resources/semcor3.0/LICENSE:
##########
Review Comment:
Given that we are in the sandbox and after reviewing
https://www.apache.org/legal/resolved.html , I think, that it is ok to include
the test resources here. If we ever migrate it to the core project, we might
want to put that resources inside the eval dataset, so the source does not
distribute this dataset.
> Investigate why LeskEvaluatorTest and MFSEvaluatorTest fail while parsing
> 'EnglishLS.train'
> -------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1446
> URL: https://issues.apache.org/jira/browse/OPENNLP-1446
> Project: OpenNLP
> Issue Type: Test
> Components: Build, Packaging and Test, wsd
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.2
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> The _LeskEvaluatorTest_ & _MFSEvaluatorTest_ in the _opennlp-wsd_ sandbox
> component both fail parsing the 'EnglishLS.train' file. The data is kept
> original, downloaded from
> {{[https://web.eecs.umich.edu/~mihalcea/senseval/senseval3/data.html]}}
> h4. {{Aims:}}
> * Investigate what causes the xml parsing to fail
> * Fix it and make both existing tests pass
> * Optional: Improve the existing test code to be more strict.
> h4. Note:
> The test setup to reproduce this is on a branch and to be merged into the
> main branch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
