[ 
https://issues.apache.org/jira/browse/OPENNLP-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853993#comment-17853993
 ] 

ASF GitHub Bot commented on OPENNLP-1567:
-----------------------------------------

rzo1 opened a new pull request, #606:
URL: https://github.com/apache/opennlp/pull/606

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [x] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   
   This adds a proof-of-conept implementation as a separate module (due to the 
addtional dependendy for classpath scanning) to load models from JAR files. 
   
   If we are fine with the design, we can do a first model release afterwards 
;-)
   




> OpenNLP Models: Provide a Finder / Loader Implementation
> --------------------------------------------------------
>
>                 Key: OPENNLP-1567
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1567
>             Project: OpenNLP
>          Issue Type: New Feature
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 2.3.4, 2.4.0
>
>
> as the title says



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to