[
https://issues.apache.org/jira/browse/OPENNLP-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863515#comment-17863515
]
ASF GitHub Bot commented on OPENNLP-1590:
-----------------------------------------
mawiesne opened a new pull request, #633:
URL: https://github.com/apache/opennlp/pull/633
Change
-
- adjusts `DictionaryFeatureGeneratorFactory` to handle situations without a
ResourceManager instance at runtime
- fixes a missing Exception type in catch block of
`GeneratorFactory#buildGenerator `which wasn't handled correctly
- clears TODO in GeneratorFactoryTest
- adds another test case to demonstrate that a descriptively declared
dictionary is loaded for the creation of a `DictionaryFeatureGeneratorFactory`
- adds a related test resource
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Clear open TODO in GenericFactoryTest
> -------------------------------------
>
> Key: OPENNLP-1590
> URL: https://issues.apache.org/jira/browse/OPENNLP-1590
> Project: OpenNLP
> Issue Type: Test
> Affects Versions: 2.3.3
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.4.0
>
>
> The test case _testDictionaryArtifactToSerializerMappingExtraction()_ in
> _GeneratorFactoryTest_ has a TODO note that can be cleared by adjusting the
> test case slightly, as well as the related inconsistent implementation
> class(es).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
