[
https://issues.apache.org/jira/browse/OPENNLP-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864535#comment-17864535
]
ASF GitHub Bot commented on OPENNLP-1592:
-----------------------------------------
mawiesne commented on PR #155:
URL: https://github.com/apache/opennlp-sandbox/pull/155#issuecomment-2219844426
> Assuming there is no risk of having issues (concurrent access, shared
access by different users/callers incorrectly, etc.) by making the dictionary
static instead of one per instance, I think this looks like a great
improvement! 👍
Good point. From what I see in the source of `edu.mit.jwi.RamDirectory`, no
changes are possible once the dictionary is populated at constructor level.
After initialization only read access is made via the API of that class.
IMHO, we are good to go, to use it as a static resource here.
> Provide tests for MetaSummarizer
> --------------------------------
>
> Key: OPENNLP-1592
> URL: https://issues.apache.org/jira/browse/OPENNLP-1592
> Project: OpenNLP
> Issue Type: Test
> Components: Summarizer
> Affects Versions: 2.3.3
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Major
> Fix For: 2.4.0
>
>
> The summarizer (sandbox) component lacks Tests for MetaSummarizer.java.
> Currently, only an orphaned main method exists in the corresponding class.
> Therefore, it is much desirable to have a fix set of tests that demonstrate
> this class actually works (Note: it doesn't as is).
> Aims:
> * Provide a minimal set of tests for MetaSummarizer
> * Improve the existing code so that summarization works (again)
> * Improve the code quality
> * Add JavaDoc where possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
