[ 
https://issues.apache.org/jira/browse/OPENNLP-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879574#comment-17879574
 ] 

ASF GitHub Bot commented on OPENNLP-1600:
-----------------------------------------

rzo1 commented on code in PR #649:
URL: https://github.com/apache/opennlp/pull/649#discussion_r1745596107


##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormat.java:
##########
@@ -23,5 +23,5 @@
  */
 public enum POSTagFormat {
 
-  UD, PENN, UNKNOWN
+  UD, PENN, CUSTOM, UNKNOWN

Review Comment:
   Would you prefer a no-op value here? I was thinking as a user wanting to 
have custom tags :) 





> Ability to disable POS mapper
> -----------------------------
>
>                 Key: OPENNLP-1600
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1600
>             Project: OpenNLP
>          Issue Type: New Feature
>          Components: POS Tagger
>    Affects Versions: 2.4.0
>            Reporter: Richard Eckart de Castilho
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 2.4.1
>
>
> Since version 2.4.0, the OpenNLP includes a mandatory POS tag mapper which 
> either maps UD to Penn POS tags or vice versa.
> Now, this is a problem if you want to train a custom model on some arbitrary 
> other POS tagset. 
> It would be great if there was a was to disable the POS mapper. 
> In fact, I would propose that POS mapping is turned off by default unless a 
> POS mapper is manually supplied to the POS tagger - so stuff would remain 
> backwards compatible.
> But at least being able to turn of the mapper and/or to provide a custom 
> mapper would be appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to