[ 
https://issues.apache.org/jira/browse/OPENNLP-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881808#comment-17881808
 ] 

ASF GitHub Bot commented on OPENNLP-1607:
-----------------------------------------

codyfearer opened a new pull request, #652:
URL: https://github.com/apache/opennlp/pull/652

   Updated SimpleClassPathModelFinder to return a list of paths instead of the 
delimiter
   
   <img width="1055" alt="After" 
src="https://github.com/user-attachments/assets/7414bab6-80c0-4192-a405-cd2e85b5951c";>
   
   
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for 
build issues and submit an update to your PR as soon as possible.
   




> SimpleClassPathModelFinder is not parsing classpath properly
> ------------------------------------------------------------
>
>                 Key: OPENNLP-1607
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1607
>             Project: OpenNLP
>          Issue Type: Bug
>            Reporter: Cody Fearer
>            Priority: Major
>         Attachments: Before.png
>
>
> The getClassPathElements method in SimpleClassPathModelFinder is not parsing 
> the classpath properly. The Matcher returns a list of delimiters instead of 
> the paths.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to