[
https://issues.apache.org/jira/browse/OPENNLP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893719#comment-17893719
]
ASF GitHub Bot commented on OPENNLP-1631:
-----------------------------------------
mawiesne opened a new pull request, #674:
URL: https://github.com/apache/opennlp/pull/674
Change
-
- converts the three existing test classes to "IT" ending so that they get
executed during failsafe plugin phase
- adds new 18 languages for each model type (sent, pos, tokens)
- fixes missing language checks for "nl" (Dutch) in `DownloadParserTest`
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Convert existing ModelLoader tests to integration tests
> --------------------------------------------------------
>
> Key: OPENNLP-1631
> URL: https://issues.apache.org/jira/browse/OPENNLP-1631
> Project: OpenNLP
> Issue Type: Sub-task
> Components: Build, Packaging and Test
> Affects Versions: 2.4.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.4.1
>
>
> We have three test classes that try to load model (ud) files for certain
> languages:
> * POSModelLoaderTest.java
> * SentenceModelLoaderTest.java
> * TokenizerModelLoaderTest.java
> within the _opennlp.tools.cmdline_ package.
> However, those actually behave like an IT. Therefore, those should be renamed
> and executed within failsafe plugin phase, separately from the JUnit
> (surefire) phase.
> Morever, we need to add more (all 23) supported model languages. Currently,
> the integration test idea for all three classes only uses EN and DE for
> testing if the corresponding model files can be loaded against the current
> code base.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
