[
https://issues.apache.org/jira/browse/OPENNLP-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895118#comment-17895118
]
ASF GitHub Bot commented on OPENNLP-1548:
-----------------------------------------
rzo1 opened a new pull request, #679:
URL: https://github.com/apache/opennlp/pull/679
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
It is safe to close the stream at this point as the streams are only opened
in this class and placed in the listeners. After that, the streams aren't
reused, so it's OK to close them. If something isn't written, force it to be
flushed before closing.
> Cleanup handling of output streams in cmdline tools
> ---------------------------------------------------
>
> Key: OPENNLP-1548
> URL: https://issues.apache.org/jira/browse/OPENNLP-1548
> Project: OpenNLP
> Issue Type: Task
> Components: Command Line Interface
> Affects Versions: 2.3.3
> Reporter: Martin Wiesner
> Assignee: Richard Zowalla
> Priority: Minor
>
> Several classes in the opennlp.tools.cmdline package carry an unresolved TODO
> stating:
> * "is it a problem to close the stream now?"
> This should be checked and cleared for all occurrences, so that no TODO
> questions are present in the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
