[jira] [Commented] (OPENNLP-1666) Switch to pre-trained UD models in Similarity component

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/OPENNLP-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905284#comment-17905284
 ] 

ASF GitHub Bot commented on OPENNLP-1666:
-----------------------------------------

kinow commented on code in PR #195:
URL: https://github.com/apache/opennlp-sandbox/pull/195#discussion_r1882825708


##########
pom.xml:
##########
@@ -158,22 +158,38 @@
                 <artifactId>slf4j-api</artifactId>
                 <version>${slf4j.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.slf4j</groupId>
+                <artifactId>log4j-over-slf4j</artifactId>
+                <version>${slf4j.version}</version>
+                <scope>runtime</scope>
+            </dependency>
 
             <dependency>
                 <groupId>commons-lang</groupId>
                 <artifactId>commons-lang</artifactId>
                 <version>2.6</version>
             </dependency>
+            <dependency>
+                <groupId>commons-io</groupId>
+                <artifactId>commons-io</artifactId>
+                <version>2.18.0</version>
+            </dependency>
             <dependency>
                 <groupId>org.apache.commons</groupId>
                 <artifactId>commons-lang3</artifactId>
-                <version>3.12.0</version>
+                <version>3.17.0</version>
             </dependency>
             <dependency>
                 <groupId>commons-codec</groupId>
                 <artifactId>commons-codec</artifactId>
                 <version>1.15</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-mat3</artifactId>

Review Comment:
   math3?





> Switch to pre-trained UD models in Similarity component
> -------------------------------------------------------
>
>                 Key: OPENNLP-1666
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1666
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Similarity
>    Affects Versions: 2.5.1
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Major
>             Fix For: 2.5.2
>
>
> Atm, the opennlp-similarity sandbox component uses old (v1.5) models for 
> testing, contained as binary artifacts in the test resources directory.
> Aims:
> Get rid of this dependency on old model files
> Switch to new pre-trained UD models (via OPENNLP_DOWNLOAD_HOME), maven 
> artifacts can be added in a separate issue
> Make the existing tests pass with the UD based models
> Modernize and tidy up some existing code structures in terms of API and 
> efficiency



--
This message was sent by Atlassian Jira
(v8.20.10#820010)