[ 
https://issues.apache.org/jira/browse/OPENNLP-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Zowalla closed OPENNLP-1688.
------------------------------------
    Fix Version/s: 2.5.4
       Resolution: Fixed

> Add GH action to test binaries (*nix + win) in GH actions
> ---------------------------------------------------------
>
>                 Key: OPENNLP-1688
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1688
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: 2.5.2
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 2.5.4
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> As shown by https://issues.apache.org/jira/browse/OPENNLP-1675 and 
> https://issues.apache.org/jira/browse/OPENNLP-1687 we are "blind" for our 
> shell / powershell scripts in terms of test coverage. In the past, we also 
> had some reports regarding a broken Windows exec, so it would be beneficial 
> to have tests here.
> We should add GH action-based testing for those scripts. The brew guys are 
> doing this as follows (with ruby though):
> {code:java}
>   test do    assert_equal "Hello , friends", pipe_output("#{bin}/opennlp 
> SimpleTokenizer", "Hello, friends").lines.first.chomp  end {code}
>  
>  
> cf. [https://github.com/Homebrew/homebrew-core/pull/202547/files]
> We could implement something similar with GitHub actions for our use case. 
> The SimpleTokenizer test should be sufficient as a first test (and can 
> subsequently enhanced with further testing).
> For implementing and testing locally, it might be useful to have a look at 
> [https://github.com/nektos/act] to simulate the GH action locally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to