[
https://issues.apache.org/jira/browse/OPENNLP-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916033#comment-17916033
]
ASF GitHub Bot commented on OPENNLP-1698:
-----------------------------------------
rzo1 commented on code in PR #60:
URL: https://github.com/apache/opennlp-addons/pull/60#discussion_r1925209228
##########
jwnl-addon/pom.xml:
##########
@@ -33,17 +33,28 @@
<packaging>jar</packaging>
<name>Apache OpenNLP JWNL Addon</name>
+ <properties>
+ <extjwnl.version>2.0.5</extjwnl.version>
+ <wn-data.version>1.2</wn-data.version>
+ </properties>
+
<dependencies>
<dependency>
<groupId>org.apache.opennlp</groupId>
<artifactId>opennlp-tools</artifactId>
</dependency>
<dependency>
- <groupId>net.sf.jwordnet</groupId>
- <artifactId>jwnl</artifactId>
- <version>1.3.3</version>
- <scope>compile</scope>
+ <groupId>net.sf.extjwnl</groupId>
+ <artifactId>extjwnl</artifactId>
+ <version>${extjwnl.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>net.sf.extjwnl</groupId>
+ <artifactId>extjwnl-data-wn31</artifactId>
Review Comment:
This artifact has a rather special license (not BSD-3 as the main artifact).
Can we add `<optional>true</optional>` here ?
> Switch to extjwnl in jwnl-addon
> -------------------------------
>
> Key: OPENNLP-1698
> URL: https://issues.apache.org/jira/browse/OPENNLP-1698
> Project: OpenNLP
> Issue Type: Task
> Affects Versions: 2.5.3
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.5.4
>
>
> The jwnl-addon component relies on an ancient dependency net.sf.jwordnet#jwnl.
> There is a newer variant: [extJWNL|https://github.com/extjwnl/extjwnl]
> (Extended Java WordNet Library), a Java API for creating, reading and
> updating dictionaries in WordNet format.
> The project uses it in the sandbox components already. However, we did forget
> to migrate the jwnl-addon. Let's correct and align this now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
