[
https://issues.apache.org/jira/browse/OPENNLP-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916334#comment-17916334
]
ASF GitHub Bot commented on OPENNLP-1700:
-----------------------------------------
mawiesne opened a new pull request, #61:
URL: https://github.com/apache/opennlp-addons/pull/61
Change
-
- fixes use of raw types
- fixes use of readers/writers without try-with-resources
- adds constants where applicable
- fixes indentations where necessary
- adds JavaDoc where useful
- removes superfluous JavaDoc
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Modernize code of geolinker addon
> ---------------------------------
>
> Key: OPENNLP-1700
> URL: https://issues.apache.org/jira/browse/OPENNLP-1700
> Project: OpenNLP
> Issue Type: Improvement
> Components: Entity Linker
> Affects Versions: 2.5.3
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.5.4
>
>
> The geolinker addon shows some raw use of parameterized types. This should
> be optimized. Moreover, other language migration aids can be applied. In
> addition, several unsafe operations on resources (lack of try-with-resources
> pattern) should be fixed.
> As a bonus, code formatting and indentations can be fixed.
> Let's modernize it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
