[
https://issues.apache.org/jira/browse/OPENNLP-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948254#comment-17948254
]
Nishant Shrivastava edited comment on OPENNLP-1711 at 4/29/25 6:53 PM:
-----------------------------------------------------------------------
Just some thoughts on this item.
In addition to moving the classes from
{code:java}
opennlp-tools/src/main/java/opennlp/tools/cmdline{code}
to the new module, it may require some more refactoring? An example below.
Assuming the expected approach is :
* Create a new module opennlp-cli and make it dependent on opennlp-tools
module.
* Move all classes
from package -
{code:java}
opennlp-tools/src/main/java/opennlp/tools/cmdline{code}
to package -
{code:java}
opennlp-cli/src/main/java/opennlp/tools/cmdline{code}
* Apply step#2 for tests classes as well.
Consider this dependency:
_opennlp-tools/src/main/java/opennlp/tools/parser/ParserEvaluator.java_
depends upon
_opennlp-cli/src/main/java/opennlp/tools/cmdline/parser/ParserTool.java_
To deal with it, we may want to move some more classes from
opennlp-tools/src/main/java/opennlp/tools/parser/
to the new module. This however becomes challenging as there are non-CLI
related classes in opennlp-tools which depend upon
CLI related classes in opennlp-cli. There are ways to solve this via some code
changes, which could be discussed.
was (Author: JIRAUSER301199):
Just some thoughts on this item.
In addition to moving the classes from
{code:java}
opennlp-tools/src/main/java/opennlp/tools/cmdline{code}
to the new module, it may require some more refactoring? An example below.
Assuming the expected approach is :
* Create a new module opennlp-cli and make it dependent on opennlp-tools
module.
* Move all classes
from package -
{code:java}
opennlp-tools/src/main/java/opennlp/tools/cmdline{code}
to package -
{code:java}
opennlp-cli/src/main/java/opennlp/tools/cmdline{code}
* Apply step#2 for tests classes as well.
Consider this dependency:
_opennlp-tools/src/main/java/opennlp/tools/parser/ParserEvaluator.java_
depends upon
_opennlp-cli/src/main/java/opennlp/tools/cmdline/parser/ParserTool.java_
To deal with it, we may want to move some more classes from
opennlp-tools/src/main/java/opennlp/tools/parser/
to the new module. This however becomes challenging as there are non-CLI
related classes in opennlp-tools which depend upon
CLI related classes in opennlp-cli. There are ways to solve this via some code
changes, which could be discussed.
> Introduce opennlp-cli module
> ----------------------------
>
> Key: OPENNLP-1711
> URL: https://issues.apache.org/jira/browse/OPENNLP-1711
> Project: OpenNLP
> Issue Type: Task
> Components: Command Line Interface
> Reporter: Martin Wiesner
> Priority: Minor
> Fix For: 3.0.0
>
>
> This module shall contain classes which reside in the _current_ cli package
> of opennlp-tools (2.x).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
