[ 
https://issues.apache.org/jira/browse/OPENNLP-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Wiesner updated OPENNLP-1733:
------------------------------------
    Summary: Remove implements Serializable from LanguageDetector  (was: Remove 
implements Serializable from LanguageDetector interface)

> Remove implements Serializable from LanguageDetector
> ----------------------------------------------------
>
>                 Key: OPENNLP-1733
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1733
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Language Detector
>    Affects Versions: 2.5.4
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>             Fix For: 2.5.5
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since OPENNLP-1258, _LanguageDetector_ interface implements 
> {_}Serializable{_}. However, there is no reason due to the service character 
> of _LanguageDetector._ 
> In this context, _LanguageDetectorModel_ implements _Serializable_ which is 
> logical and required for persisting models of that kind. Still, the +service+ 
> on top of this model type has no functional need for being serialized.
> Currently, the +javac+ raises a compiler warning for 
> _ThreadSafeLanguageDetectorME_ which does provide a _@Serial_ annotated 
> field. Yet, this is not required at all. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to