[
https://issues.apache.org/jira/browse/OPENNLP-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081906#comment-18081906
]
ASF GitHub Bot commented on OPENNLP-1738:
-----------------------------------------
mawiesne opened a new pull request, #478:
URL: https://github.com/apache/opennlp-sandbox/pull/478
Change
-
- reactivates the test by removing the @DisabledOnOs annotation
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> WSDisambiguatorMETest randomly fails under Linux on GH actions
> --------------------------------------------------------------
>
> Key: OPENNLP-1738
> URL: https://issues.apache.org/jira/browse/OPENNLP-1738
> Project: OpenNLP
> Issue Type: Bug
> Components: sandbox, wsd
> Affects Versions: 2.5.4
> Reporter: Richard Zowalla
> Priority: Major
>
> We have failing sandbox test on the WSD component on GH actions for Ubuntu
> (24.04) Latest Runners with JDK 21 (temurin) and JDK 24-ea
>
> Error:
> opennlp.tools.disambiguator.WSDisambiguatorMETest.testDisambiguateOneWord –
> Time elapsed: 0.007 s <<< FAILURE!org.opentest4j.AssertionFailedError: Check
> 'please' sense ID ==> expected: <WORDNET please%4:02:00::> but was: <WORDNET
> please%2:37:00::>
>
> The input into the test is similar between OS:
>
> The input is similar between Windows/OSX and Linux:
> Ubuntu:
> [We, need, to, discuss, an, important, topic, ,, please, write, to, me, soon,
> .]
> [PRP, VB, RP, VB, DT, JJ, NN, ., UH, VB, IN, PRP, RB, .]
> [we, need, to, discuss, a, important, topic, ,, please, write, to, i, soon, .]
> Mac / Windows:
> We, need, to, discuss, an, important, topic, ,, please, write, to, me, soon,
> .]
> [PRP, VB, RP, VB, DT, JJ, NN, ., UH, VB, IN, PRP, RB, .]
> [we, need, to, discuss, a, important, topic, ,, please, write, to, i, soon, .]
> Older version of Sandbox for Mac:
> [We, need, to, discuss, an, important, topic, ,, please, write, to, me, soon,
> .]
> [PRP, VB, RP, VB, DT, JJ, NN, ., UH, VB, IN, PRP, RB, .]
> [we, need, to, discuss, a, important, topic, ,, please, write, to, i, soon, .]
>
> ----
>
> In addition, older commits are also failing with the issue above, which
> indicates an environment issue.
> I did some tests on a Gitlab Runner (Ubuntu 24.04 Latest Docker with JDK 21)
> and German locale, which does not fail. I also did some tests on an Ubuntu
> 24.04 Desktop system hosted on VDI infrastructure with German locale and
> could not reproduce the test failures.
> It must be an environment and / or locale issue on the GH action runners.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
