Kristian Rickert created OPENNLP-1882:
-----------------------------------------

             Summary: Stemmer tests are excluded from surefire and never run
                 Key: OPENNLP-1882
                 URL: https://issues.apache.org/jira/browse/OPENNLP-1882
             Project: OpenNLP
          Issue Type: Bug
          Components: Build, Packaging and Test
    Affects Versions: 3.0.0-M4
            Reporter: Kristian Rickert
            Assignee: Kristian Rickert
             Fix For: 3.0.0-M5


OPENNLP-997 (2017) excluded `**/stemmer/*` and `**/stemmer/snowball/*` from the 
JaCoCo coverage report to keep generated Snowball code out of coverage metrics. 
The same excludes were also copied into the surefire configuration (root pom 
plus opennlp-tools, opennlp-runtime, opennlp-cli, opennlp-formats), so no test 
under a stemmer package has run in any Maven build since.

This hid a stale test: OPENNLP-1701 regenerated the Snowball code, whose 
Turkish algorithm now removes proper-noun suffixes after an apostrophe 
(`r_remove_proper_noun_suffix`), and `SnowballStemmerTest#testTurkish` still 
expected the old behavior. The updated expectations follow the snowball-data 
reference vocabulary.

Fix: remove the stemmer excludes from surefire (keeping them in JaCoCo), fix 
the Turkish expectations. Unhides 26 existing tests; the full runtime suite 
passes.




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to