[
https://issues.apache.org/jira/browse/OPENNLP-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125451#comment-18125451
]
ASF GitHub Bot commented on OPENNLP-1982:
-----------------------------------------
mawiesne opened a new pull request, #1462:
URL: https://github.com/apache/opennlp/pull/1462
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a GitHub issue associated with this PR? Is it referenced
in the PR description (e.g. "Fixes #1234")?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> SentenceVectorsDL cannot run on a GPU
> -------------------------------------
>
> Key: OPENNLP-1982
> URL: https://issues.apache.org/jira/browse/OPENNLP-1982
> Project: OpenNLP
> Issue Type: Bug
> Affects Versions: 2.5.12, 3.0.0-M6
> Reporter: Richard Zowalla
> Assignee: Kristian Rickert
> Priority: Minor
> Fix For: 3.0.0
>
>
> {{SentenceVectorsDL}} always creates default {{OrtSession.SessionOptions}},
> so unlike {{NameFinderDL}} and {{DocumentCategorizerDL}} it cannot use the
> CUDA execution provider through {{InferenceOptions}}. Add a constructor that
> takes {{InferenceOptions}} and, once OPENNLP\-1937 is in, expose the device
> \(e.g. {{cpu}} / {{cuda:N}}\), a maximum batch size and the intra\-op thread
> count as options of the ONNX text embedder provider.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
