[
https://issues.apache.org/jira/browse/OPENNLP-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126298#comment-18126298
]
ASF GitHub Bot commented on OPENNLP-1991:
-----------------------------------------
krickert commented on PR #1323:
URL: https://github.com/apache/opennlp/pull/1323#issuecomment-6123812554
Thanks for the review. All five blockers and the minors are addressed in the
current push:
- `FeedforwardDependencyModel` extends `BaseModel`, with the network as an
artifact with its own serializer.
- Training takes `TrainingParameters`; `Settings` is package-private.
- The scoring cache is owned by the parser, off by default and budgeted in
bytes.
- One forward and backward pass and one log-softmax, shared by parsing,
training and refinement.
- `@throws` is complete on `train` and `refine`, and
`ParamChecks.requirePositive` replaces the local checks.
The minors (loader limits through `ResourceLimits`, a versioned magic,
sorted vocabularies, shared fixtures, parameterized loader and validation
tests) are in the same push. The feedforward scores in the eval come from a new
eval run, with a beam 4 row next to the greedy one.
> Add a feedforward neural dependency parser
> ------------------------------------------
>
> Key: OPENNLP-1991
> URL: https://issues.apache.org/jira/browse/OPENNLP-1991
> Project: OpenNLP
> Issue Type: Improvement
> Reporter: Kristian Rickert
> Assignee: Kristian Rickert
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add a feedforward neural implementation of the dependency parser API
> introduced by OPENNLP-547. Use OpenNLP’s standard model container, artifact
> serializers, TrainingParameters, factory, and CLI conventions. Include
> deterministic training, greedy and beam decoding, model round-trip tests, and
> held-out Universal Dependencies evaluation. Address the deferred review
> feedback on shared scoring/training logic and parser-owned caches. Implement
> this without new dependencies.
> The list above may still get this ticket to further split. For now this is a
> placeholder to capture the code that was moved out of OPENNLP-547. I'll edit
> after 547 is merged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
