https://issues.apache.org/ooo/show_bug.cgi?id=121754

--- Comment #6 from Fred Toussi <[email protected]> ---
> That's why I think it shouldn't be committed. The Java baseline in
> OpenOffice is still 1.5 (both source and target) and there are no plans to
> change this, so a proper fix would be making the code compile with JDK7
> while generating binaries that run in 1.5.

Unfortunately it seems impossible to compile classes that implement java.sql
package interfaces to force a previous JRE target. Therefore a baseline JDK 5
is required for release builds.

But there is no harm in committing the patch (after some mods) just to make it
simpler for developers. Developers can already compile with JDK 6 as support is
built into the existing HSQLDB sources.

The patch needs changes to //#ifdef and //#endif lines as they must start at
the beginning of the line (example below)

+ public class jdbcConnection implements Connection {
++//#ifdef JAVA7

The build.xml must also be updated to include a target for JDK7, something
like:

<target name="switchtojdk17" depends="switchtojdk16" ...

You can look at build.xml for hsqldb 2.2.x for an example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

Reply via email to