https://issues.apache.org/ooo/show_bug.cgi?id=121733
Ariel Constenla-Haile <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Ariel Constenla-Haile <[email protected]> --- (In reply to comment #0) > Created attachment 80226 [details] > patch file > > Modify SwWrongArea so that it holds the color and line-style that are used > in order to paint the corresponding marking line. > Add functionality to SwWrongArea that evaluates the XStringKeyMap parameter > of its constructor. > The SmartTagRecognizer can explicitly specify the color of the markings by > adding entries "Red", "Green", "Blue" to the > string key map where the content of these keys is a hexadecimal string > representation of the color component values. > The default color of all other wrong list types has not been changed. If one > adds a smart tag without specification of the color, > it would get the default smart tag color. This would be more compliant with the rest of the API if the XStringKeyMap has a key "LineColor" and the value is css::util::Color > Furthermore, the SmartTagRecognizer can specify the line type of the smart > tag by addition of an entry "LineStyle" that can > have the values "WAVE", "WAVE_NORMAL", "WAVE_SMALL", "WAVE_FLAT". The > default line style is dashed. Here too, instead of strings, use css::awt::FontUnderline > Modify the drawing function lcl_DrawWrongListData so that it uses the color > and style information contained in the SwWrongArea > elements rather than determining the color and style of each marking within > this function each time it is called. I'm not convinced about given so much control to the extension developer. At least, the application code sure ensure that the extension settings do not overlap with other settings, so that the smart tag can uniquely be identified as such by the user. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
