https://bz.apache.org/ooo/show_bug.cgi?id=128557
Issue ID: 128557
Issue Type: DEFECT
Summary: Comment to a changed cell - minor flaws
Product: Calc
Version: 3.3.0 or older (OOo)
Hardware: PC
OS: Windows, all
Status: UNCONFIRMED
Severity: Trivial
Priority: P5 (lowest)
Component: ui
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
Steps to demonstrate:
1. Open a new Calc document
2. Turn on change tracking via Edit - Changes - Record
3. Select any cell and type something into it
4. Select this cell
5. Choose Edit - Changes - Comment and add a comment
6. Close the dialog
7. Rest your mouse pointer over the said cell
Calc will display a callout containing:
- author's first and last name, date and time of change
- comment,
- description of change.
for example:
John Doe, 01/25/2023 19:01:06:
comment line
comment line
( Cell B5 changed from '<empty>' to '123.456')
Notice that:
(1)
There is a colon at the end of the first line/part.
Keep in mind the French might require a leading space
(":" is hardcoded...) and that Writer doesn't display
the colon in a callout.
Could the content of the callout really be misunderstood
without the colon?
(2)
there is a superfluous space after "("
in the line describing the recorded change.
The Accept or Reject Changes dialog doesn't show it.
Expected result:
no colon (1) and no space (2).
--------------------------------------
Possible source code pointer:
/aoo41x/main/sc/source/ui/view/gridwin5.cxx
Line 182 (colon) & 187 (space)
176 DateTime aDT = pFound->GetDateTime();
177 aTrackText = pFound->GetUser();
178 aTrackText.AppendAscii(RTL_CONSTASCII_STRINGPARAM( ", " ));
179 aTrackText += ScGlobal::pLocaleData->getDate(aDT);
180 aTrackText += ' ';
181 aTrackText += ScGlobal::pLocaleData->getTime(aDT);
182 aTrackText.AppendAscii(RTL_CONSTASCII_STRINGPARAM( ":\n" ));
183 String aComStr=pFound->GetComment();
184 if(aComStr.Len()>0)
185 {
186 aTrackText += aComStr;
187 aTrackText.AppendAscii(RTL_CONSTASCII_STRINGPARAM( "\n( " ));
188 }
189 pFound->GetDescription( aTrackText, pDoc );
190 if(aComStr.Len()>0)
191 {
192 aTrackText +=')';
193 }
--
You are receiving this mail because:
You are the assignee for the issue.
