https://issues.apache.org/ooo/show_bug.cgi?id=121960

Andre <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|121420                      |

--- Comment #19 from Andre <[email protected]> ---
I further improved the creation of toolbox/toolbar controllers.  The ultimate
goal, however, should be to use the toolbarmanger class from framework/
directly, not just borrowing code from it.  But I don't want to change this
class before the 4.0 release.

The original motivation for the changes was to use standard toolbar controllers
for the font selection and font size controls in the TextPropertyPanel.  This
in itself is not hard to do but the buttons for increasing and decreasing the
font size are making problems.  The code for all these controls is very
interwoven.  In Writer and Draw/Impress the standard controls for
increase/decrease could be used, their disabling when the font size reaches an
upper or lower limit (72/4 pt in Writer, 0.2/999.9 pt in Draw/Impress) had to
be added.  For Calc, however, this does not work because there are no
slots/commands for increase/decrease.

The seemingly simple change to use standard controllers would require a lot of
code changes and new features.  I do not have the time to do this now and am
not willing to risk and regressions caused by such changes.

We will have to fix and problems with disabled or intercepted (bug 122024) on
demand when there is a concrete problem.  For the time being I therefore remove
this issue as blocker of bug 121420.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to