https://issues.apache.org/ooo/show_bug.cgi?id=120020

Andre <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80882|                            |review?
              Flags|                            |

--- Comment #5 from Andre <[email protected]> ---
Created attachment 80882
  --> https://issues.apache.org/ooo/attachment.cgi?id=80882&action=edit
Do not delete linked undo actions.

The crash is triggered in ~SfxLinkUndoAction() when the pAction member is
accessed.  This member is destroyed a little earlier by UndoManagerGuard().

The root cause is that undo actions are not reference counted and that
ownership is not clearly defined.

The attached patch prevents undo actions from being deleted in
~UndoManagerGuard() when they are linked.  This would work under the assumption
that linked actions would be destroyed by their owners.  But that seems to not
be the case.  Therefore the patch prevents the crash for the cost of leaking
undo action objects.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

Reply via email to