Andrea Pescetti <[email protected]> has canceled Regina Henschel
<[email protected]>'s request for review:
Bug 121754: Build HSQLDB with JDK 7
https://issues.apache.org/ooo/show_bug.cgi?id=121754

Attachment 81042: remove the failiing part
https://issues.apache.org/ooo/attachment.cgi?id=81042&action=edit


------- Additional Comments from Andrea Pescetti <[email protected]>
Status: this new patch removes all ^M characters (line-ends problems) and only
keeps the code differences, thus removing readme and HTML files. If you examine
the options given to diff, you'll see that I had to fiddle with line-ends due
to the fact that the two versions have different line-end conventions. So the
patch was not mixing line-ends per se, it was a diff between files with
different line-ends conventions.

Tested like the other time: hsqldb module built successfully under Java 6 and 7
(Linux). Regina, thanks for your feedback and if you now can build on Windows
too then this should be fine.

Reply via email to