https://issues.apache.org/ooo/show_bug.cgi?id=122840

--- Comment #15 from Oliver-Rainer Wittmann <[email protected]> ---
(In reply to Clarence GUO from comment #14)
> 
> [snip]
> 
> I'm not sure whether it is his pen mistake, but from logic, as he only add a
> new parameter for scope identification, the old parameters should not be
> changed. So I just change (*aItr)->sContent back to sTempContent, then it
> works.
> And there's no problem on 120478 sample file with the fix. I did some test,
> haven't find problem.
> But I don't know why we need to pass a "0" string as content into the
> method. Does anybody knows that?

That is the defect cause and the solution as well.
Applying "0" as content when adding a named range is done by purpose as far as
I can see from the code in <ScXMLImport::SetNamedRanges()>. There two loops in
this methods. The first inserts the named ranges. The second applies the
content incl. the grammar to the inserted ranges. Thus, I conclude that it is
done by purpose.

I also agree to your conclusion that by bug 120478 only the <scope name> has
been added for the insertion of the named ranges.

Please contribute the corresponding patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

Reply via email to