https://issues.apache.org/ooo/show_bug.cgi?id=122927

--- Comment #26 from Oliver-Rainer Wittmann <[email protected]> ---
(In reply to Clarence GUO from comment #24)
> I agree with Oliver's modification against my patch.
> About the problem mentioned by Oliver with his new code, Microsoft Excel
> document attached to bug 121126 shows wrong display for cells A5:A7, I think
> it makes sense because MS Excel applied customized number format to these
> cells. If the manner(applying number format should work no matter what type
> of a formula returned) for old AOO users is a rule. According to the rule,
> the behavior is correct unless we want to change behavior 100% same with
> that in MS Excel.
> Thus it's pity that the fix code of additional handling with logical
> formulas in 121126 is more or less redundant now because most number format
> can be categorized into number, currency, percent, date, time... formats
> with or without NUMBERFORMAT_DEFINED flag. So that code seldom work I think.
> But after all anyway it will work under some scenarios, for example, create
> a XLS by Excel and input "=2>1" to a cell, and apply text number format to
> it, in AOO3.4.0, it shows 1, but in AOO4.0 plus Oliver's new code, it shows
> TRUE like that in Excel. If you haven't apply text number format, in
> AOO3.4.0, there is no problem, also shows TRUE. I'm not sure whether
> returning 1 for a text logical format is a defect or not. It doesn't make
> sense from my personal perspective.

Ok.
Thus, do you agree that my proposed solution could be integrated into branch
AOO401 for our planned AOO 4.0.1 release?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

Reply via email to