https://issues.apache.org/ooo/show_bug.cgi?id=123478

--- Comment #11 from Armin Le Grand <[email protected]> ---
ALG: This is so unbelievable, I am shocked myself; I use an temporarily
instance of BitmapBuffer when creating a GDI+ Bitmap object to get to 24bit
color depth. That class gets filled by calling StretchAndConvert, filling the
allocated memory with the 24bit temporary data. After using it, it gets
deleted.
But: A look at the class BitmapBuffer shows:

                    BitmapBuffer(){}
                    ~BitmapBuffer() {}

ARGH! It does neither initialize nor cleanup the memory that struct is
administrating (!). Sorry, I did not control the implementation of that struct,
it is actively used in VCL. I hate that old stuff, this means that all usages
of that struct in the current code have to and do manage that memory handish.
ARGH! Who did stuff like that?

To fix, I cannot even safely add a free memory to the constructor, this would
require to identify all places where that memory is controlled handish; to
safely fix this I will also have to free the mem controlled by that struct by
hand...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

Reply via email to