https://issues.apache.org/ooo/show_bug.cgi?id=122494

--- Comment #4 from Andrea Pescetti <[email protected]> ---
Created attachment 82184
  --> https://issues.apache.org/ooo/attachment.cgi?id=82184&action=edit
A version of the patch that can be applied to 4.0.1

The code was reorganized in different folders and files since the version Habib
wrote his patch for, and it had also undergone several internal changes, so the
patch failed to apply in multiple spots.

I'm attaching a reworked version of the patch that applies to OpenOffice 4.0.1
or the current trunk.

Remarks:

1) The patch has not been tested at all, and it should be, since the underlying
code changed.

2) The relative path to wz_jsgraphics.js may have changed and may have to be
fixed.

3) Comments, whitespace changes and attribution to Habib have been ignored in
this patch (Habib, of course you will receive proper credit, but we will do as
for all other contributors; we don't write names in the source code, to keep it
clean).

4) The <xsl:template match="draw:frame"> section (line 918 of the patched
odf2xhtml/export/common/body.xsl) changed substantially and should be reviewed
to check that the patch is still doing what it was meant for.

5) A couple of AL2 headers appear to have changed, but this is just due to
inconsistent newline handling; they are untouched and this part of the patch
can be ignored.

6) The patch is not yet ready to be committed; for example, it includes an
external JavaScript library that must still be sorted. I'm providing it so that
integration can continue.

Next step will be to divide Habib's work in separate patches to make it more
manageable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

Reply via email to