https://issues.apache.org/ooo/show_bug.cgi?id=124065
--- Comment #5 from Andre <[email protected]> --- I totally agree that avoiding the cloning would be a good idea. I am just trying to make sure that there are no side effects when the cloning is removed. The method GetRangeName is defined in sc/inc/document.hxx as public: ... SC_DLLPUBLIC ScRangeName* GetRangeName(); so it is not only public but also accessible from outside of the sc module. That means that when the returned ScRangeName object is modified because it is not cloned anymore and local copies are modified, then that can cause subtle side effects in and outside of sc. If that is just a hypothetical problem (because nobody calls GetRangeName() at the moment, or does not store a pointer to the returned ScRangenName object or does not expect it not to change) then it might be best to avoid future problems in this area by - Documenting clearly in sc/in/document.hxx that the returned ScRangeName is volatile, ie can change at any time. - Removing the SC_DLLPUBLIC specifier (if possible) - Making it private (if possible) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
